feat: add zerolog (#46) - Check spanCtx using IsValid

hertz-contrib · Jan 26, 2024 · 1a5c657 · 1a5c657
1 parent 30ae4c8
commit 1a5c657
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/logging/zerolog/option.go b/logging/zerolog/option.go
@@ -85,12 +85,12 @@ func (cfg config) getZerologHookFn() zerolog.HookFunc {
 		span := trace.SpanFromContext(ctx)
 		spanCtx := span.SpanContext()
 
-		if spanCtx.HasSpanID() {
-			e.Any(SpanIDKey, spanCtx.SpanID())
-		}
-		if spanCtx.HasTraceID() {
-			e.Any(TraceIDKey, spanCtx.TraceID())
+		if !spanCtx.IsValid() {
+			return
 		}
+
+		e.Any(SpanIDKey, spanCtx.SpanID())
+		e.Any(TraceIDKey, spanCtx.TraceID())
 		e.Any(TraceFlagsKey, spanCtx.TraceFlags())
 
 		if !span.IsRecording() {