Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Logger using zerolog #47

Merged
merged 7 commits into from
Jan 27, 2024
Merged

feat: Logger using zerolog #47

merged 7 commits into from
Jan 27, 2024

Conversation

lovung
Copy link
Contributor

@lovung lovung commented Jan 24, 2024

What type of PR is this?

feat: Logger using zerolog

What this PR does / why we need it (English/Chinese):

Close #46

Which issue(s) this PR fixes:

Missing zerolog when integrate with OpenTelemetry

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2024

CLA assistant check
All committers have signed the CLA.

@lovung lovung marked this pull request as draft January 24, 2024 15:06
@lovung lovung marked this pull request as ready for review January 25, 2024 13:58
logging/zerolog/logger.go Outdated Show resolved Hide resolved
logging/zerolog/logger.go Show resolved Hide resolved
logging/zerolog/logger_test.go Show resolved Hide resolved
@lovung lovung self-assigned this Jan 26, 2024
@lovung lovung added enhancement New feature or request good first issue Good for newcomers labels Jan 26, 2024
@rogerogers rogerogers removed enhancement New feature or request good first issue Good for newcomers labels Jan 27, 2024
@li-jin-gou li-jin-gou merged commit 8af1031 into hertz-contrib:main Jan 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support zerolog as logging
4 participants