Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow extraVolumes and extraVolumeMounts in helm chart #743

Closed
hegerdes opened this issue Sep 10, 2024 · 2 comments · Fixed by #744 · May be fixed by #723
Closed

feat: allow extraVolumes and extraVolumeMounts in helm chart #743

hegerdes opened this issue Sep 10, 2024 · 2 comments · Fixed by #744 · May be fixed by #723
Assignees
Labels
enhancement New feature or request

Comments

@hegerdes
Copy link
Contributor

hegerdes commented Sep 10, 2024

TL;DR

The user @simonostendorf provided the great feature in #652 to read the HCLOUD_TOKEN from an file! It is great having the possibility to read the token from a file since leaking files is much less likely then envs.

Unfortunately I have a hard time using this feature when you don't use HashiCorps Secret injector. Normally you would mount the secret as a volume but you cant do this currently since the chart does not support any extraVolumes or extraVolumeMounts. But this is kind of needed when you use CSI Secret Driver or just want to mount the k8s secret as a file.

Expected behavior

Being able to set extraVolumes or extraVolumeMounts so I can use my existing k8s secret and mount it as file via secret-key-ref oder to use a kubernetes secret csi driver definition as volume.

Is this something worth supporting? I would happily provide a PR if this is an accepted feature from Hetzner.

Update:
PR in #744

@hegerdes hegerdes added the enhancement New feature or request label Sep 10, 2024
@simonostendorf
Copy link
Contributor

I think supporting the CSI Secret Driver would be great.

(And cool that someone uses my feature :))

@apricote
Copy link
Member

Sounds good, happy to accept a pull request for this :)

hegerdes added a commit to hegerdes/hcloud-cloud-controller-manager that referenced this issue Sep 11, 2024
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
hegerdes added a commit to hegerdes/hcloud-cloud-controller-manager that referenced this issue Sep 13, 2024
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants