Implement support for custom internal IP mapping via HCLOUD_INSTANCES… #696
+78
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @elohmeier, thanks for the PR! Our team is a little bit short on time right now with vacations, so the review is going to take some more weeks. I am sorry for this. |
|
Thanks for you message, no problem. I wonder if there is upstream interest for this addition? If so, please let me know - I would then take a look into the CI issues and rebase. |
|
This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs. |
elohmeier
force-pushed
the
hcloud-instances-internal-ip-map
branch
from
d72734f
to
9198a4f
Compare
|
Rebased onto latest main branch. |
…_INTERNAL_IP_MAP This update adds the ability to specify custom internal IP addresses for Hetzner Cloud and Robot Instances through the `HCLOUD_INSTANCES_INTERNAL_IP_MAP` environment variable.
elohmeier
force-pushed
the
hcloud-instances-internal-ip-map
branch
from
9198a4f
to
c4d6635
Compare
|
@elohmeier Can you add a usage example for how to specify the mapping? Tried your PR but neither got the IP added nor an error in HCLOUD_INSTANCES_INTERNAL_IP_MAP:
nodename: 'nodeip'
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds the ability to specify custom internal IP addresses for Hetzner Cloud and Robot Instances through the
HCLOUD_INSTANCES_INTERNAL_IP_MAPenvironment variable.This is especially useful when mixing cloud servers with dedicated robot servers via vSwitch / private networks. Users will need to manage the IPs of the robot servers manually anyway, this change let users specify them as well for the InternalIp field in K8S.