Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not transform property names for standalone clients #616

Merged
merged 1 commit into from
May 24, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented May 24, 2024

Closes #615

Copy link

stackblitz bot commented May 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented May 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 1:49am

@mrlubos mrlubos marked this pull request as ready for review May 24, 2024 01:48
Copy link

changeset-bot bot commented May 24, 2024

🦋 Changeset detected

Latest commit: 735561c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hey-api/client-fetch Patch
@hey-api/openapi-ts Patch
@example/openapi-ts-fetch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 24.03433% with 177 lines in your changes are missing coverage. Please review.

Project coverage is 75.45%. Comparing base (17b982c) to head (735561c).

Files Patch % Lines
packages/openapi-ts/src/utils/write/types.ts 0.59% 167 Missing ⚠️
packages/openapi-ts/src/utils/write/type.ts 30.00% 7 Missing ⚠️
...pi-ts/src/openApi/v2/parser/getModelComposition.ts 0.00% 1 Missing ⚠️
...-ts/src/openApi/v2/parser/getOperationParameter.ts 85.71% 1 Missing ⚠️
...-ts/src/openApi/v3/parser/getOperationParameter.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
- Coverage   75.46%   75.45%   -0.01%     
==========================================
  Files          75       75              
  Lines        7270     7312      +42     
  Branches      660      663       +3     
==========================================
+ Hits         5486     5517      +31     
- Misses       1781     1792      +11     
  Partials        3        3              
Flag Coverage Δ
unittests 75.45% <24.03%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit 637c86c into main May 24, 2024
14 of 16 checks passed
@mrlubos mrlubos deleted the fix/client-beta-4 branch May 24, 2024 01:53
@github-actions github-actions bot mentioned this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fetch client: snake_case path arguments get converted to camelCase in types, but not in template string
1 participant