Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate the correct error types instead of unknown #672

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

gergan
Copy link
Contributor

@gergan gergan commented Jun 12, 2024

Hi, I'm not sure if it was just a typo but this pull request fixes #641 for me.

Copy link

stackblitz bot commented Jun 12, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jun 12, 2024

⚠️ No Changeset found

Latest commit: c8fa6fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2024 1:49pm

@mrlubos
Copy link
Member

mrlubos commented Jun 12, 2024

Potentially. I'll have a look, thanks @gergan!

Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you're right, thanks @gergan!

Copy link

codecov bot commented Jun 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.67%. Comparing base (a4eef0f) to head (c8fa6fc).

Files Patch % Lines
packages/openapi-ts/src/utils/write/types.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #672   +/-   ##
=======================================
  Coverage   75.67%   75.67%           
=======================================
  Files          74       74           
  Lines        7400     7400           
  Branches      692      692           
=======================================
  Hits         5600     5600           
  Misses       1797     1797           
  Partials        3        3           
Flag Coverage Δ
unittests 75.67% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit a6db4e6 into hey-api:main Jun 16, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error types are unknown with v0.46.3
2 participants