-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export type RequestResult of fetch client #698
Conversation
Run & review this pull request in StackBlitz Codeflow. |
🦋 Changeset detectedLatest commit: fc2b166 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #698 +/- ##
=======================================
Coverage 70.89% 70.89%
=======================================
Files 76 76
Lines 7984 7984
Branches 696 696
=======================================
Hits 5660 5660
Misses 2321 2321
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you create a patch changeset please?
c759054
to
fc2b166
Compare
@mrlubos Sure, just added it! |
@mrlubos Hey, this PR was actually ineffectual: the type is still made private after going through rollup. I force-pushed a fix on the same branch and made sure it builds as expected. Apologies for my mistake... Please let me know if I should open a new PR |
Sure |
This aims to improve usability of generated fetch clients. Fixes #693