Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make getHeaders() accept generic #708

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Jun 22, 2024

Closes #706

Copy link

vercel bot commented Jun 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 1:09am

Copy link

changeset-bot bot commented Jun 22, 2024

🦋 Changeset detected

Latest commit: 36cf95d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrlubos mrlubos marked this pull request as ready for review June 22, 2024 01:09
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.06%. Comparing base (c20c139) to head (36cf95d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #708   +/-   ##
=======================================
  Coverage   71.06%   71.06%           
=======================================
  Files          76       76           
  Lines        8034     8034           
  Branches      710      710           
=======================================
  Hits         5709     5709           
  Misses       2321     2321           
  Partials        4        4           
Flag Coverage Δ
unittests 71.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit 0e79f7b into main Jun 22, 2024
16 checks passed
@mrlubos mrlubos deleted the fix/types-additional-headers branch June 22, 2024 01:17
@github-actions github-actions bot mentioned this pull request Jun 22, 2024
Copy link

stackblitz bot commented Jun 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spread types may only be created from object types issue for additionalHeaders in generated requests.ts
1 participant