fix: infinite loop in transforms #712
Conversation
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 0ce82e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
==========================================
- Coverage 71.06% 69.67% -1.39%
==========================================
Files 76 78 +2
Lines 8034 8267 +233
Branches 710 709 -1
==========================================
+ Hits 5709 5760 +51
- Misses 2321 2502 +181
- Partials 4 5 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| if (config.debug) { | ||
| console.warn( | ||
| `⚠️ Transformers warning: route ${operation.method} ${operation.path} has ${responses.length} success responses. This is currently not handled and we will not generate a response transformer. Please open an issue if you'd like this feature https://github.com/hey-api/openapi-ts/issues`, | ||
| ); |
There was a problem hiding this comment.
I do think putting this behind a debug flag is inviting people to have weird issues and blame the package. If it fires it should be because a type IS wrong and that's something devs need to know up front
| thenStatement: ts.factory.createBlock(statements), | ||
| }), | ||
| ]; | ||
| }) |
There was a problem hiding this comment.
What happens if there's an endpoint with two different models on responses? Looks like this attempts to handle it but there's no test?
There was a problem hiding this comment.
Do you have an example? It's meant to handle only FooResponse | void and there's a snapshot for that
There was a problem hiding this comment.
Ah you're right, i missed that you're still bailing out for 2+ non-void models.
Should be easy to adapt to support multiple responses when one of us has time for
Closes #705