Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle references to schemas with illegal names #786

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Jul 17, 2024

Closes #768

Copy link

stackblitz bot commented Jul 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 0:46am

Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: 20759e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 80.55556% with 14 lines in your changes missing coverage. Please review.

Project coverage is 73.95%. Comparing base (274851b) to head (20759e2).

Files Patch % Lines
packages/openapi-ts/src/utils/type.ts 12.50% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #786      +/-   ##
==========================================
- Coverage   74.00%   73.95%   -0.05%     
==========================================
  Files          77       79       +2     
  Lines        8359     8393      +34     
  Branches      781      783       +2     
==========================================
+ Hits         6186     6207      +21     
- Misses       2169     2182      +13     
  Partials        4        4              
Flag Coverage Δ
unittests 73.95% <80.55%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit 5c9c654 into main Jul 17, 2024
15 of 16 checks passed
@mrlubos mrlubos deleted the fix/illegal-name-ref branch July 17, 2024 12:51
@github-actions github-actions bot mentioned this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"import" isn't always renamed to "_import" when generating schema
1 participant