Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: combine reading spec from url #81

Closed
wants to merge 1 commit into from
Closed

feat: combine reading spec from url #81

wants to merge 1 commit into from

Conversation

jordanshatford
Copy link
Collaborator

in the future if we want to support other url sources (like ftp, etc.) we can

mrlubos
mrlubos reviewed Mar 18, 2024
View reviewed changes
Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jordanshatford do you want to add tests for these?

@jordanshatford
Copy link
Collaborator Author

@jordanshatford do you want to add tests for these?

Might need to wait to test these properly. There wasnt any previous tests and I am not entirely sure how to mock the HTTP request.

@mrlubos mrlubos mentioned this pull request Mar 19, 2024
Merged
@mrlubos mrlubos closed this in #88 Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrlubos mrlubos mrlubos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordanshatford @mrlubos