Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

複数バージョンのNode.jsでテストするようにする & 新しめのNode.jsで動かなかったのを修正 #9

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

White-Green
Copy link
Collaborator

@White-Green White-Green commented Oct 31, 2024

Node.js 20以降に対しては、Host headerを付けていないと400が返ってくるらしいので付けるようにしました

@White-Green White-Green changed the title 複数バージョンのNode.jsでテストするようにする 複数バージョンのNode.jsでテストするようにする & 新しめのNode.jsで動かなかったのを修正 Oct 31, 2024
@White-Green White-Green marked this pull request as ready for review October 31, 2024 06:47
@White-Green White-Green requested a review from riseshia October 31, 2024 06:53
Copy link
Contributor

@riseshia riseshia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Host がないとこまる、なるほど....????? いいんだけどこれどうやって調べたのかやや気になります 👀

@White-Green White-Green merged commit 1b379e8 into heyinc:main Nov 1, 2024
12 checks passed
@White-Green White-Green deleted the nodejs-versions branch November 1, 2024 02:21
@White-Green White-Green mentioned this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants