Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

Commit

Permalink
instanceof -> is, require 4.13
Browse files Browse the repository at this point in the history
  • Loading branch information
fredemmott committed Jul 17, 2019
1 parent 083e02e commit 054039b
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ sudo: required
language: generic
services: docker
env:
- HHVM_VERSION=4.6-latest
- HHVM_VERSION=4.13-latest
- HHVM_VERSION=latest
- HHVM_VERSION=nightly
install:
Expand Down
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"keywords": ["hack", "router", "routing", "hhvm"],
"homepage": "https://github.com/hhvm/hack-router-codegen",
"require": {
"hhvm": "^4.6",
"facebook/hack-router": "^0.18",
"hhvm": "^4.13",
"facebook/hack-router": "^0.19",
"facebook/hack-http-request-response-interfaces": "^0.2",
"facebook/hack-codegen": "^4.1.0",
"facebook/definition-finder": "^2.7",
Expand Down
2 changes: 1 addition & 1 deletion src/privateimpl/ClassFacts.hack
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ final class ClassFacts {
): ImmMap<classname<T>, ScannedClass> {
$mappable = Map { };
foreach ($this->classes as $class) {
if (!$class instanceof ScannedClass) {
if (!$class is ScannedClass) {
continue;
}
$name = $this->asClassname($wanted, $class->getName());
Expand Down
2 changes: 1 addition & 1 deletion src/privateimpl/ControllerFacts.hack
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ final class ControllerFacts<T as IncludeInUriMap> {
private function isUriMappable(
ScannedClassish $class
): bool {
if (!$class instanceof ScannedClass) {
if (!$class is ScannedClass) {
return false;
}
if ($class->isAbstract()) {
Expand Down
2 changes: 1 addition & 1 deletion src/uriparameters/spec/EnumParameterCodegenSpec.hack
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ final class EnumParameterCodegenSpec extends UriParameterCodegenSpec {
RequestParameter $param,
): EnumRequestParameter<T> {
invariant(
$param instanceof EnumRequestParameter,
$param is EnumRequestParameter<_>,
'Expected %s to be an enum parameter, got %s',
$param->getName(),
\get_class($param),
Expand Down
2 changes: 1 addition & 1 deletion tests/RouterCodegenBuilderTest.hack
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ final class RouterCodegenBuilderTest extends BaseCodegenTestCase {
self::CODEGEN_NS,
'MySiteRouter',
);
assert($class instanceof \Facebook\HackCodegen\CodegenFile);
assert($class is \Facebook\HackCodegen\CodegenFile);
return $class->render();
}

Expand Down

0 comments on commit 054039b

Please sign in to comment.