convert properties passed to Agroal to strings #9490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note that the "garbage cast" in the TODO actually resulted in a bad user experience
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
gavinking
force-pushed
the
agroalprops
branch
from
ab04163 to
eaa9592
Compare
gavinking
force-pushed
the
agroalprops
branch
from
eaa9592 to
4180967
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| throw new ServiceException( "Specified JDBC Driver " + driverClassName + " could not be loaded", e1 ); | ||
| else { | ||
| try { | ||
| return (Driver) Class.forName( driverClassName ).newInstance(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| throw new ServiceException( "Specified ConnectionCreatorFactory " + connectionCreatorFactoryClassName + " could not be loaded", e1 ); | ||
| else { | ||
| try { | ||
| return (ConnectionCreatorFactory) Class.forName( connectionCreatorFactoryClassName ).newInstance(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
should have done this a long time ago :) also a bunch of refactoring to make connection pool config more robust
gavinking
force-pushed
the
agroalprops
branch
from
b47e603 to
ee66c43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note that the "garbage cast" in the TODO actually
resulted in a bad user experience
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.