Remove floating point types from types advertised to support precision & scale #4559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
adferrand
force-pushed
the
bugfix/noscale-for-floating
branch
3 times, most recently
from
edc4218
to
37cb871
Compare
…rt precision & scale
adferrand
force-pushed
the
bugfix/noscale-for-floating
branch
from
37cb871
to
a95da86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to HBX-1408
This PR fixes an inconsistency in Java entities generation. Indeed
hibernate-toolsgenerate entities whose floating point type fields are annotated with a@Typewithscaleandprecisionparameters. However these parameters are not relevant and generateIllegalArgumentExceptionas per https://github.com/hibernate/hibernate-orm/blob/7c58fe9a16eb15e5d1432e4bb3434c89cf214e16/hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java#L5097-L5112.This PR changes
JdbcToHibernateTypeHelperso thattypeHasScaleAndPrecisiondo not advertise these types to support scale and precision.