Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HV-2053: Add Azerbaijani (az) locale support to validation messages #1469

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

Maharramoff
Copy link
Contributor

Jira issue HV-2053

  • Unicode encoding applied for Azerbaijani-specific characters (e.g., ə, ç, ş, ü, ö, ğ, ı).
  • Implemented custom EL syntax logic to handle Azerbaijani suffixes (-dan and -dən) accurately.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Oct 15, 2024

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

- Apply unicode to Azerbaijani-specific characters (e.g., `ə`, `ç`, `ş`, `ü`, `ö`, `ğ`, `ı`)
- Implement custom EL syntax logic to handle Azerbaijani suffixes (`-dan` and `-dən`) accurately
@marko-bekhta
Copy link
Member

Hey, thanks for providing the pull request.
there are a few more constraints available, any chance you can add translations for those as well? e.g.

org.hibernate.validator.constraints.BitcoinAddress.message.single = must be a valid Bitcoin address for the type:
org.hibernate.validator.constraints.BitcoinAddress.message.multiple = must be a valid Bitcoin address for one of these types:
org.hibernate.validator.constraints.BitcoinAddress.type.p2pkh = Legacy (P2PKH)
org.hibernate.validator.constraints.BitcoinAddress.type.p2sh = Nested SegWit (P2SH)
org.hibernate.validator.constraints.BitcoinAddress.type.bech32 = Native SegWit (Bech32)
org.hibernate.validator.constraints.BitcoinAddress.type.p2wsh = SegWit variant of P2SH (P2WSH)
org.hibernate.validator.constraints.BitcoinAddress.type.p2wpkh = SegWit variant of P2PKH (P2WPKH)
org.hibernate.validator.constraints.BitcoinAddress.type.p2tr = Taproot (P2TR)
or
org.hibernate.validator.constraints.kor.KorRRN.message = invalid Korean resident registration number (KorRRN)

(and maybe others haven't compared the lists)

…ssages

- Added translations for KorRRN and BitcoinAddress constraints
- Removed translations not present in default properties file
- Reformatted file to align columns

Updates hibernate#1469
@Maharramoff
Copy link
Contributor Author

@marko-bekhta

Copy link
Member

@marko-bekhta marko-bekhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marko-bekhta marko-bekhta merged commit fa15e3f into hibernate:main Oct 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants