Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add videos and filtering to "our feed" page #42

Closed
wants to merge 28 commits into from

Conversation

kchenturtles
Copy link
Contributor

No description provided.

@kchenturtles kchenturtles requested a review from am5815 July 17, 2024 14:28
@am5815
Copy link
Collaborator

am5815 commented Jul 17, 2024

Ok very good, can I request a few more updates?

  • I think the filtering functionality needs more work. If you click two filters, it sort of crashes, and the UI is not intuitive in that it's not obvious that the chips you have there allow you to filter.
  • By default, I think you can have all the filters selected.
  • Ordering of the content, at this point, the videos seem to be on the end of the list, maybe do it so they are sorted by date they were added.
  • Can you allow for the admin to enter a brief description for the videos and display that as the text on the card as opposed to the description of the video coming from the API.

@am5815
Copy link
Collaborator

am5815 commented Jul 19, 2024

A few things:
Filtering - If audio available is selected and article is not, it should show the articles that have audio available on them. At present it is now showing anything.
Sample voices - Select your voice has disappeared and I can't select anything:
Screenshot 2024-07-19 at 1 56 36 PM
Width of cards is inconsistent:
Screenshot 2024-07-19 at 1 57 16 PM

@am5815
Copy link
Collaborator

am5815 commented Jul 19, 2024

Also, when playing on the article card component, there is no audio, this might be because no audio is selected.

Copy link
Collaborator

@am5815 am5815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments on the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants