You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 9, 2021. It is now read-only.
But this is bad UX. A user may accidentally attempt to withdraw more debt that they have. They should simply be refunded the surplus instead of reverting the execution of the contract call.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
The current behaviour of the protocol is that it reverts if the
repayAmount
is bigger than thedebtAmount
, when callingrepayBorrow
:https://github.com/hifi-finance/hifi-protocol/blob/main/contracts/core/balanceSheet/BalanceSheetV1.sol#L565-L569
But this is bad UX. A user may accidentally attempt to withdraw more debt that they have. They should simply be refunded the surplus instead of reverting the execution of the contract call.
Beta Was this translation helpful? Give feedback.
All reactions