shell check fixes

high-performance-spark · Aug 15, 2024 · f504154 · f504154
1 parent 3344bc6
commit f504154
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/build_container.sh b/build_container.sh
@@ -19,5 +19,5 @@ VERSION=${VERSION:-0.4}
 IMAGE=${IMAGE:-holdenk/hps:$VERSION}
 MINI_IMAGE=${MINI_IMAGE:-holdenk/hps-mini:$VERSION}
 docker buildx build --platform=linux/amd64,linux/arm64 -t "${MINI_IMAGE}" -f Dockerfile-mini .  --push
-docker buildx build --platform=linux/amd64,linux/arm64 -t "${IMAGE}" .  --push --build-arg base=${MINI_IMAGE}
+docker buildx build --platform=linux/amd64,linux/arm64 -t "${IMAGE}" .  --push --build-arg base="${MINI_IMAGE}"
 #docker buildx build --platform=linux/amd64 -t "${IMAGE}" .  --push
diff --git a/run_container.sh b/run_container.sh
@@ -4,7 +4,7 @@ VERSION=${VERSION:-0.4}
 IMAGE=${IMAGE:-holdenk/hps:$VERSION}
 export VERSION
 export IMAGE
-docker image pull $IMAGE
+docker image pull "$IMAGE"
 mkdir -p warehouse
 mkdir -p iceberg-workshop
-docker container  run --mount type=bind,source="$(pwd)"/warehouse,target=/high-performance-spark-examples/warehouse --mount type=bind,source="$(pwd)/iceberg-workshop",target=/high-performance-spark-examples/iceberg-workshop -p 8877:8877 -p 4040:4040 -it ${IMAGE} # /bin/bash
+docker container  run --mount type=bind,source="$(pwd)"/warehouse,target=/high-performance-spark-examples/warehouse --mount type=bind,source="$(pwd)/iceberg-workshop",target=/high-performance-spark-examples/iceberg-workshop -p 8877:8877 -p 4040:4040 -it "${IMAGE}" # /bin/bash