Skip to content

Commit

Permalink
Merge pull request #469 from highcharts/master
Browse files Browse the repository at this point in the history
3.1
  • Loading branch information
cvasseng authored Jan 18, 2024
2 parents b9282bc + aaaf0fa commit 5652b07
Show file tree
Hide file tree
Showing 22 changed files with 434 additions and 691 deletions.
10 changes: 7 additions & 3 deletions .env.sample
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@ EXPORT_DEFAULT_CONSTR = chart
EXPORT_DEFAULT_HEIGHT = 400
EXPORT_DEFAULT_WIDTH = 600
EXPORT_DEFAULT_SCALE = 1
EXPORT_RASTERIZATION_TIMEOUT = 1500

# Highcharts config
HIGHCHARTS_VERSION = latest
HIGHCHARTS_CDN = https://code.highcharts.com/
HIGHCHARTS_FORCE_FETCH = false
HIGHCHARTS_CORE_SCRIPTS =
HIGHCHARTS_MODULES =
HIGHCHARTS_INDICATORS =
Expand Down Expand Up @@ -40,10 +42,12 @@ HIGHCHARTS_RATE_LIMIT_SKIP_TOKEN =
HIGHCHARTS_POOL_MIN_WORKERS = 8
HIGHCHARTS_POOL_MAX_WORKERS = 8
HIGHCHARTS_POOL_WORK_LIMIT = 40
HIGHCHARTS_POOL_QUEUE_SIZE = 5
HIGHCHARTS_POOL_TIMEOUT = 5000
HIGHCHARTS_POOL_ACQUIRE_TIMEOUT = 5000
HIGHCHARTS_POOL_ENABLE_REAPER = true
HIGHCHARTS_POOL_CREATE_TIMEOUT = 5000
HIGHCHARTS_POOL_DESTROY_TIMEOUT = 5000
HIGHCHARTS_POOL_IDLE_TIMEOUT = 30000
HIGHCHARTS_POOL_CREATE_RETRY_INTERVAL = 200
HIGHCHARTS_POOL_REAPER_INTERVAL = 1000
HIGHCHARTS_POOL_BENCHMARKING = false
HIGHCHARTS_POOL_LISTEN_TO_PROCESS_EXITS = true

Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ node_modules/
log/
tests/_temp
tmp/
dist/

.DS_Store
.cache
Expand Down
46 changes: 32 additions & 14 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,21 @@
# 3.1.0

- Fixed an issue with SVG base 64 exports
- Fixed several bugs with the worker pool
- Changed name of the `initialWorkers` option to the `minWorkers`
- Fixed hanging the server on start when initial resources (pages) couldn't be created
- Fixed clearing page after the export
- Removed the `queueSize` option, which doesn't have an equivalent in `tarn` resource pool
- Removed the `timeoutThreshold` option and added the `idleTimeout` option in its place
- Removed the `reaper` options, as tarn doesn't allow to enable/disable idle resources checking
- Added `createTimeout` and `destroyTimeout` options for the resource pool
- Added the `reaperInterval` option to set the interval for checking idle resources to destroy
- Added the `createRetryInterval` option to set how long to idle after failed resource creation before trying again
- Added the `rasterizationTimeout` option for setting the wait time for an image to be created
- Updated the `.env.sample` file with new environment variables corresponding to above options
- Updated the README file
- Other small fixes

# 3.0.5

- Fixed an issue with transparent backgrounds in PNG exports (#463)
Expand All @@ -19,17 +37,17 @@ Fixes:

FIXES:

- Changed the priority of loading options to: config -> custom JSON -> envs -> CLI.
- Corrected the The unhandledRejection error, message: Protocol error: Connection closed. Most likely the page has been closed, an error related to closing the browser earlier than closing each of an active page.
- Refactored the way options are set (the setOptions function).
- Corrected straight inject with JS functions in chart's options (e.g. formatter), when the allowCodeExecution is set to true.
- Organized code into two separate functions (singleExport and batchExport).
- Corrected reseting global options for Highcharts between each export.
- Corrections for the linter.
- Samples and tests corrections.
- Added sample for the loadConfig option.
- Updated Readme.
- Other small fixes.
- Changed the priority of loading options to: config -> custom JSON -> envs -> CLI
- Corrected the The unhandledRejection error, message: Protocol error: Connection closed. Most likely the page has been closed, an error related to closing the browser earlier than closing each of an active page
- Refactored the way options are set (the setOptions function)
- Corrected straight inject with JS functions in chart's options (e.g. formatter), when the allowCodeExecution is set to true
- Organized code into two separate functions (singleExport and batchExport)
- Corrected reseting global options for Highcharts between each export
- Corrections for the linter
- Samples and tests corrections
- Added sample for the loadConfig option
- Updated Readme
- Other small fixes

# 3.0.1

Expand Down Expand Up @@ -73,10 +91,10 @@ done unless the server is sandboxed and not reachable on the public internet.

_Changelog_

- Added the `--allowCodeExecution` flag which is now required to be set when exporting pure JavaScript, using additional external resources, or using callback when running in server mode.
- Added the `--allowCodeExecution` flag which is now required to be set when exporting pure JavaScript, using additional external resources, or using callback when running in server mode
- Removed the `mkdirp` dependency
- SVG exporting will now block JavaScript entirely
- Added the `navigationLocked` flag to the Phantom page, which blocks e.g. `<iframe>` and page redirects.
- Added the `navigationLocked` flag to the Phantom page, which blocks e.g. `<iframe>` and page redirects

# 2.0.30

Expand Down Expand Up @@ -210,7 +228,7 @@ _Changelog_

# 2.0.0

- Fixed Phantom cleanup: instead of reaping every 2.5s, workers are checked for timeout when other work is posted.
- Fixed Phantom cleanup: instead of reaping every 2.5s, workers are checked for timeout when other work is posted
- Added additional error handlers to
- `hhtp(s)Server`, `process`
- Worker busy check before restarting
Expand Down
Loading

0 comments on commit 5652b07

Please sign in to comment.