Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/disabling-logging #536

Merged
merged 12 commits into from
Jul 4, 2024
Merged

feat/disabling-logging #536

merged 12 commits into from
Jul 4, 2024

Conversation

jszuminski
Copy link
Contributor

@jszuminski jszuminski commented Jun 13, 2024

Description

Introducing options:

  • env: LOGGING_TO_FILE; cli: logToFile,
  • env: LOGGING_TO_CONSOLE; cli: logToConsole

Usage in .env

LOGGING_TO_FILE=true
LOGGING_TO_CONSOLE=false

Usage in CLI

node ./bin/cli.js --enableServer 1 --logToFile false --logToConsole true

Internal note

This PR introduced a initLoggerOptions method in the logger.js file which takes care of taking the options set by the user, not the default ones anymore which means that we can easily add/remove options for the logger which will be customizable by the user.

Copy link
Contributor

@PaulDalek PaulDalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@PaulDalek PaulDalek merged commit bc64dd4 into master Jul 4, 2024
2 checks passed
@PaulDalek PaulDalek deleted the feat/disabling-logging branch July 4, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants