-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependency to latest highlight.js 10.7.2 #16
Comments
@akollegger Could I get a link to a GitHub issue or a thread of this problem? Minor versions don't typically "break" themes - though sometimes highlighting does change slightly - which could require a theme to be updated. Otherwise I'm also not sure how bumping a dependency here would have any effect on your theme at all? |
Ok, that is OLD... all bets are off... I take back what I said. :-) it's possible something may indeed need to change if this hasn't been updated since version 9. |
I'll fix it this afternoon. Please forgive us for the inconvenience. |
Still quite curious how a theme was broken though, grammar itself looks pretty clean - so surprises. |
The break surfaced as an unsatisfied dependency. It appeared that |
Ah yes the correct package name is now |
Done, @akollegger and @joshgoebel. |
Thanks @gusbemacbe ! |
Do you mean to create a new release here? |
Actually, it's a development dependency so I'm a bit confused...
@akollegger could you please post the complete error message? |
Apologies, you're right that the dependency was not the root cause for my theme. The theme initialization api changed, which incidentally failed on requiring -ABK |
I wasn't aware we have any sort of API for themes? |
Outdated issue. |
@Mogztter Could you update this dependency? Back-tracking from a problem on community.neo4j.com, where the host has updated to the latest release, causing our theme to break.
Thank you!
-ABK
The text was updated successfully, but these errors were encountered: