[#502] : delete episodeFile if only file generated in configuration phase of m2e #503
Conversation
maven-plugin/plugin-core/src/main/java/org/jvnet/jaxb/maven/RawXJC2Mojo.java
Show resolved
Hide resolved
maven-plugin/plugin-core/src/main/java/org/jvnet/jaxb/maven/RawXJC2Mojo.java
Show resolved
Hide resolved
|
Can we add the example project as a test and validate the episode is deleted? |
| @@ -479,6 +481,7 @@ protected void doExecute() throws MojoExecutionException { | |||
| setupDirectories(); | |||
| doExecute(options); | |||
| addIfExistsToEpisodeSchemaBindings(); | |||
| deleteEpisodeIfOnlyFileOnEmptyContext(); | |||
There was a problem hiding this comment.
Wouldn't it be better to just not call doExecute instead of creating and then deleting the file?
There was a problem hiding this comment.
@alerosmile : there is some scenario (simple ones with no bindings / catalog) where files are just created the right way
There was a problem hiding this comment.
@laurentschoelens : You are right but I once read this:
https://www.eclipse.org/lists/m2e-dev/msg01178.html
maven-resources-plugin:copy-resources does nothing during onConfiguration.
There was a problem hiding this comment.
So you suggest that the runOnConfiguration should be set to false ?
There was a problem hiding this comment.
No, the source roots must be added during runOnConfiguration, but according to Igor's comment, no files should be created. I'm not sure but I think Igor is one of the main creator of m2e.
There was a problem hiding this comment.
In fact, it's working as expected with only runOnIncremental 😄
There was a problem hiding this comment.
In fact, it's working as expected with only runOnIncremental 😄
Or not 😄
I don't think so sadly 😞 |
…guration phase of m2e (tested in eclipse)
laurentschoelens
force-pushed
the
jt-502
branch
from
d0f6984
to
4cf793b
Compare
No : the problem is only in m2e 😞 |
|
See other test failures-- did this change cause a regression? |
Output maven console after the fix |
|
Thoughts on guarding this change with a config flag or state flag that detects we are running in Eclipse / m2e? |
|
No, see f574786 (fixed in other PR) |
|
Closing, will recreate new one with another fix |
Fixes #502
Does not break build
Tested in eclipse m2e sample project provided here