Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Not to consider disabled annotations as custom annotations #286

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Jan 22, 2024

Ⅰ. Describe what this PR did

Not to consider disabled annotations as custom annotations, so they won't be shown on the custom annotation area.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CH3CHO CH3CHO requested a review from xiangxiuhui as a code owner January 22, 2024 09:02
@CH3CHO CH3CHO requested a review from johnlanni January 22, 2024 09:02
@johnlanni johnlanni merged commit dcc4a19 into higress-group:main Jan 22, 2024
4 checks passed
@CH3CHO CH3CHO deleted the fix/edit-custom-anno branch January 24, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants