Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add a special note to the port field of Nacos 2.0 service source #302

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Apr 23, 2024

Ⅰ. Describe what this PR did

Add a special note to the port field of Nacos 2.0 service source, letting user know he/she needs to keep an additional port accessiable as well.

image

image

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CH3CHO CH3CHO requested a review from johnlanni April 23, 2024 10:19
@CH3CHO CH3CHO requested a review from songpengyuan as a code owner April 23, 2024 10:19
Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 26e2b6f into higress-group:main Apr 23, 2024
4 checks passed
@CH3CHO CH3CHO deleted the fix/nacos-2-port-note branch April 24, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants