Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix some bugs in AI console APIs #367

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Nov 12, 2024

Ⅰ. Describe what this PR did

  1. Grant permission to operate EnvoyFilters in helm chart.
  2. Generate fallback resources in AiRouteServiceImpl.add as well.
  3. Fill some default values shown as null previously.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

1. Grant permission to operate EnvoyFilters in helm chart.
2. Generate fallback resources in AiRouteServiceImpl.add as well.
3. Fill some default values shown as null previously.
@CH3CHO CH3CHO requested a review from johnlanni November 12, 2024 05:36
@CH3CHO CH3CHO requested a review from slievrly as a code owner November 12, 2024 05:36
Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 8f793b4 into higress-group:main Nov 12, 2024
4 checks passed
@CH3CHO CH3CHO deleted the fix/ai-console-api branch November 12, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants