Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support configuring protocol and SNI for service sources with static or dns type #379

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Dec 12, 2024

Ⅰ. Describe what this PR did

image

image

image

image

image

image

image

apiVersion: networking.higress.io/v1
kind: McpBridge
metadata:
  creationTimestamp: "2024-12-05T09:38:55Z"
  generation: 19
  name: default
  namespace: higress-system
  resourceVersion: "2054673"
  uid: f73e338c-3dc6-477e-9307-1eabe49a3ca8
spec:
  registries:
  - domain: 1.1.1.1
    nacosGroups:
    - DEFAULT_GROUP
    nacosNamespaceId: ""
    name: nacos
    port: 1233
    type: nacos2
  - domain: "123123"
    nacosGroups:
    - DEFAULT_GROUP
    nacosNamespaceId: ""
    name: nacosv2
    port: 12312
    type: nacos
  - domain: 1.1.1.1
    name: zk
    port: 123
    type: zookeeper
    zkServicesPath: []
  - domain: 123.1.1.1:1234
    name: test
    port: 80
    protocol: https
    sni: http
    type: static
  - domain: www.test.com
    name: dns
    port: 123
    protocol: grpcs
    sni: testt
    type: dns
  - domain: 123.1.1.1
    name: testev
    port: 1234
    type: eureka
  - domain: 10.1.2.3:50005
    name: local
    port: 80
    protocol: grpc
    type: static
  - domain: httpbin.org
    name: httpbin
    port: 80
    protocol: http
    type: dns
  - domain: 1.1.1.1
    nacosGroups:
    - DEFAULT_GROUP
    nacosNamespaceId: ""
    name: testnacos
    port: 1234
    type: nacos2

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

fixes #359

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CH3CHO CH3CHO requested a review from johnlanni December 12, 2024 03:04
@CH3CHO CH3CHO requested a review from songpengyuan as a code owner December 12, 2024 03:04
Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 9aa49b1 into higress-group:main Dec 12, 2024
4 checks passed
@CH3CHO CH3CHO deleted the feat/svc-src-proto-sni branch December 12, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS 和固定地址类型的服务来源支持配置后端服务协议和 SNI
2 participants