Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify helm template containerPort to avoid svc ports impact deployment readnessProbe. #382

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

ishells
Copy link
Contributor

@ishells ishells commented Dec 12, 2024

…nt readnessProbe.

Ⅰ. Describe what this PR did

  • modify helm template containerPort to avoid svc ports impact deployment readnessProbe.

Ⅱ. Does this pull request fix one issue?

fixes #381

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CH3CHO CH3CHO merged commit ffc8328 into higress-group:main Dec 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants