feat: Support generating default routes pointing to the landing page #399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Generate a default route pointing to the landing page provided by Higress Console when no Ingress resource matching following criteria is found:
global.watchedNamespace
global.watchedNamespace
is empty: This criterion shall be ignored.global.ingressClass
global.ingressClass
is empty: This criterion shall be ignored.global.ingressClass
isnginx
: Only Ingress resources withingressClassName
set tonginx
or left empty matches the criterion.global.ingressClass
is any other value: Only Ingress resources with the sameingressClassName
withglobal.ingressClass
matches the criterion.Besides the changes above, this PR also adds a new
all
query parameters to the /v1/routes API, allowing callers to get all the Ingresses watched by the contoller, not only those in the same namespace with the console itself.Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews