Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support generating default routes pointing to the landing page #399

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Jan 6, 2025

Ⅰ. Describe what this PR did

Generate a default route pointing to the landing page provided by Higress Console when no Ingress resource matching following criteria is found:

  • In a namespace watched by Higress Controller, depended on the value of global.watchedNamespace
    • global.watchedNamespace is empty: This criterion shall be ignored.
  • Bound to an IngressClass watched by Higress Controller, depended on the value of global.ingressClass
    • global.ingressClass is empty: This criterion shall be ignored.
    • global.ingressClass is nginx: Only Ingress resources with ingressClassName set to nginx or left empty matches the criterion.
    • global.ingressClass is any other value: Only Ingress resources with the same ingressClassName with global.ingressClass matches the criterion.

image

Besides the changes above, this PR also adds a new all query parameters to the /v1/routes API, allowing callers to get all the Ingresses watched by the contoller, not only those in the same namespace with the console itself.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@johnlanni johnlanni merged commit 73f0a62 into higress-group:main Jan 6, 2025
4 checks passed
@CH3CHO CH3CHO deleted the feat/default-route branch January 6, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants