Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bugs in AI console pages #403

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Jan 12, 2025

Ⅰ. Describe what this PR did

Fix bugs in AI console pages.

  1. Fix the missing default values of token failover feature issue.
  2. Fix localization issues in AI console pages.
  3. Fix the incorrect token masking logic when the token value is shorter than 6 characters.
  4. Make sure auth plugin configurations created via consumer management are always globally enabled.
  5. Clean up localization resources.
  6. Remove redundant UI pages.
  7. Fix some display issues in the TLS certificate page.
    a. Remove duplicated domains from the domain list.
    b. Add a "Z" suffix to the not-before and not-after timestamps so user can know they are UTC times.
  8. Fix the bug that after adding a TLS certificate to the default domain, the HTTPS requests don't work with the default domain.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 4717038 into higress-group:main Jan 14, 2025
4 checks passed
@CH3CHO CH3CHO deleted the fix/ai-console-web branch January 14, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants