Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unique timezone for multiple agencies #28

Open
mehdisadeghi opened this issue Dec 19, 2017 · 4 comments
Open

unique timezone for multiple agencies #28

mehdisadeghi opened this issue Dec 19, 2017 · 4 comments
Labels

Comments

@mehdisadeghi
Copy link
Contributor

GTFS document states:

If multiple agencies are specified in the feed, each must have the same agency_timezone.

Does this mean that we can't produce GTFS feeds for regions stretching over multiple time zones?

@carocad
Copy link
Contributor

carocad commented Jan 8, 2018

@mehdisadeghi I would guess that our smart calculations are an over-engineered solution 😆. I guess we could simply check the timezone of the geometric middle point of the region.

Based on the GTFS description I would say that this restricts GTFS files to a country as maximum region; although multi-timezones countries would be problematic. Maybe a bug in the definition? or is there a technical aspect that we are forgetting?

@mehdisadeghi
Copy link
Contributor Author

we could simply check the timezone of the geometric middle point of the region.

That sounds like a good idea!

Maybe a bug in the definition? or is there a technical aspect that we are forgetting?

The best way to find out this would be checking some existing feeds.

mehdisadeghi added a commit that referenced this issue Mar 2, 2018
Guessing timezone causes validation errors at the moment.
See #28.
mehdisadeghi added a commit that referenced this issue Mar 10, 2018
Guessing timezone causes validation errors at the moment.
See #28.


Former-commit-id: 2469cee
@mehdisadeghi
Copy link
Contributor Author

we could simply check the timezone of the geometric middle point of the region.

@carocad what about explicitly asking for the timezone instead of guesswork?

@carocad
Copy link
Contributor

carocad commented May 22, 2018

Good idea

However I would still make that optional. The user should be able to choose the Timezone but if not provided we would just go with our best guest

mehdisadeghi added a commit that referenced this issue Oct 23, 2018
Guessing timezone causes validation errors at the moment.
See #28.


Former-commit-id: 2469cee
Former-commit-id: c6e7205
mehdisadeghi added a commit that referenced this issue Oct 23, 2018
Guessing timezone causes validation errors at the moment.
See #28.


Former-commit-id: 3e8bec4 [formerly 2469cee]
Former-commit-id: 96a5f7c [formerly c6e7205]
Former-commit-id: 608a927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants