Laplace approximation to posterior #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uvilla
requested changes
Apr 11, 2024
uvilla
reviewed
Apr 12, 2024
uvilla
requested changes
Apr 15, 2024
example/sfsi_toy_gaussian.py
Outdated
|
|
||
| noise = prior.generate_parameter("noise") | ||
|
|
||
| ###################################################### |
There was a problem hiding this comment.
See comment above (multiple samples in the same file)
| prior, | ||
| d: np.array, | ||
| U: MultiVector, | ||
| createVecLeft=None, |
There was a problem hiding this comment.
Also here:
createVecLeft and createVecRight are not needed
| if len(args) == 2: | ||
| self._sample_given_prior(args[0], args[1]) | ||
| if add_mean: | ||
| temp_petsc_vec_arg1 = dlx.la.create_petsc_vector_wrap(args[1]) |
There was a problem hiding this comment.
very confusing. Should it just be:
args[1].array[:] += self.mean.array
There was a problem hiding this comment.
This has been fixed here. Thanks for pointing this out:
hippylibx/hippylibX/modeling/laplaceApproximation.py
Lines 191 to 202 in b096580
added 9 commits
April 15, 2024 14:25
uvilla
reviewed
Apr 17, 2024
| def createVecLeft(self) -> petsc4py.PETSc.Vec: | ||
| return self.prior.R.createVecLeft() | ||
|
|
||
| def sample(self, noise: dlx.la.Vector, s: dlx.la.Vector): |
uvilla
approved these changes
Apr 20, 2024
.github/workflows/CI_testing.yml
Outdated
| cd ./hippylibX/test && | ||
| mpirun -n 2 python3 test_lowRankHessian.py | ||
|
|
||
| - name: low rank Hessian precondtioner testing |
There was a problem hiding this comment.
Spelling changed. Thanks for pointing it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding modeling/laplaceApproximation.py and algorithms/lowRankOperator.py