Feature/26650 payload sampling #591
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DC2-DanielKrueger
force-pushed
the
feature/26650-payload-sampling
branch
from
ee882c6
to
30f175e
Compare
DC2-DanielKrueger
force-pushed
the
epic/tag-integration-backend-frontend
branch
from
83488d1
to
feb5308
Compare
DC2-DanielKrueger
force-pushed
the
feature/26650-payload-sampling
branch
from
30f175e
to
bb016ea
Compare
codepitbull
requested changes
Oct 16, 2024
| public @NotNull Response getSchemaForTopic(@NotNull final String topicBase64) { | ||
| final String topic = new String(Base64.getDecoder().decode(topicBase64), StandardCharsets.UTF_8); | ||
| final List<byte[]> samples = samplingService.getSamples(topic); | ||
| if (samples.isEmpty()) { |
| try { | ||
| jsonSamples.add(objectMapper.readTree(sample)); | ||
| } catch (final IOException e) { | ||
| // TODO |
There was a problem hiding this comment.
question is whether we should log the broken payload here. Guess the Exception message must be enough.
| if (customBridgeLimitations != null) { | ||
| final Long queueLimitFromConfig = customBridgeLimitations.queueLimit; | ||
| if (queueLimitFromConfig != null) { | ||
| // bridges can overwrite the default |
There was a problem hiding this comment.
I would log something like this on info.
There was a problem hiding this comment.
no we shouldnt do this. This would scale the log messages linear with the amount of messages. Logging even competes for exclusive access => contention.
| } | ||
|
|
||
| public void startSampling(final @NotNull String topic) { | ||
| final String clientId = SAMPLER_PREFIX + topic; |
| clientId); | ||
| } | ||
|
|
||
| public void stopSampling(final @NotNull String topic) { |
| localTopicTree.removeSubscriber(clientId, topic, null); | ||
| } | ||
|
|
||
| public @NotNull List<byte[]> getSamples(final @NotNull String topic) { |
There was a problem hiding this comment.
Logs and a metric would be great.
There was a problem hiding this comment.
what should the metric measure? Invocations? Number of returned samples? When would this metric help?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hivemq.kanbanize.com/ctrl_board/57/cards/26650/details/