Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cache origins #16

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Conversation

QuentinMoss
Copy link
Contributor

Add support for origin cache using @hjr3 recommendations in #1

@hjr3
Copy link
Owner

hjr3 commented Jul 1, 2023

check out QuentinMoss#6

@QuentinMoss QuentinMoss changed the title feat(WIP): Cache origin feat(): Cache origin Jul 1, 2023
@QuentinMoss QuentinMoss requested a review from hjr3 July 1, 2023 17:47
@QuentinMoss
Copy link
Contributor Author

@hjr3 This is ✨. Thanks for the improvements.

@QuentinMoss QuentinMoss changed the title feat(): Cache origin feat: Cache origins Jul 1, 2023
@QuentinMoss QuentinMoss self-assigned this Jul 2, 2023
@QuentinMoss QuentinMoss added enhancement New feature or request WIP Not ready for merge labels Jul 2, 2023
@QuentinMoss QuentinMoss force-pushed the qm-implement-origin-caching branch 3 times, most recently from 977a6b8 to b211d8d Compare July 2, 2023 22:18
QuentinMoss and others added 3 commits July 2, 2023 15:20
Add support for origin caching
- hide away Arc details
- use dependency injection
- create a retry queue implementation instead of returning pool
  directly to main
@QuentinMoss QuentinMoss removed the WIP Not ready for merge label Jul 2, 2023
@QuentinMoss QuentinMoss force-pushed the qm-implement-origin-caching branch 2 times, most recently from 43e5c5d to cbfa948 Compare July 2, 2023 22:56
@QuentinMoss
Copy link
Contributor Author

Me right now.

giphy

@hjr3 hjr3 merged commit 5de4fca into hjr3:main Jul 6, 2023
@hjr3
Copy link
Owner

hjr3 commented Jul 6, 2023

great work on this!

@QuentinMoss QuentinMoss deleted the qm-implement-origin-caching branch July 6, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants