Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clean up nested ingest span logging #17

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

QuentinMoss
Copy link
Contributor

It seems handler trace was not closing scope properly when router was called async.

When sending a large number of requests to a successful endpoint I noticed that the span name was appending ingest. Notice the span names start appending ingest.

2023-07-01T03:12:14.875392Z TRACE ingest: soldr::db: insert_request
2023-07-01T03:12:14.875795Z DEBUG ingest: soldr::proxy: authority = example.wh.soldr.dev
2023-07-01T03:12:14.875827Z TRACE ingest: soldr::db: list_origins
2023-07-01T03:12:14.876075Z DEBUG soldr::proxy: origins = []
2023-07-01T03:12:14.876096Z TRACE soldr::proxy: no match found
2023-07-01T03:12:14.876121Z TRACE soldr::db: mark_complete
2023-07-01T03:12:14.884002Z DEBUG ingest:ingest: soldr: HttpRequest { method: "POST", uri: "/", headers: [("host", "example.wh.soldr.dev"), ("user-agent", "curl/7.81.0"), ("accept", "*/*"), ("content-length", "0"), ("content-type", "application/x-www-form-urlencoded")], body: Some([]) }
2023-07-01T03:12:14.884062Z TRACE ingest:ingest: soldr::db: insert_request
2023-07-01T03:12:14.884451Z DEBUG ingest:ingest: soldr::proxy: authority = example.wh.soldr.dev
2023-07-01T03:12:14.884477Z TRACE ingest:ingest: soldr::db: list_origins
2023-07-01T03:12:14.884635Z DEBUG soldr::proxy: origins = []
2023-07-01T03:12:14.884654Z TRACE soldr::proxy: no match found
2023-07-01T03:12:14.884671Z TRACE soldr::db: mark_complete
2023-07-01T03:12:14.892296Z DEBUG ingest:ingest:ingest: soldr: HttpRequest { method: "POST", uri: "/", headers: [("host", "example.wh.soldr.dev"), ("user-agent", "curl/7.81.0"), ("accept", "*/*"), ("content-length", "0"), ("content-type", "application/x-www-form-urlencoded")], body: Some([]) }

@hjr3 hjr3 merged commit f79072b into hjr3:main Jul 1, 2023
@QuentinMoss QuentinMoss deleted the qm-clean-up-tracing-output branch July 1, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants