(WIP) Replace goxsys IsAnInteractiveSession with IsWindowsService #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream goxsys deprecated IsAnInteractiveSession. Refs hlandau#17
|
Actually, hmm, hold off on this for a while, might be other issues with this. |
JeremyRand
changed the title
|
Yeah, hmm, this breaks ncdns for reasons I am unclear on. Possibly related to the usage of a restricted service user. Will try to investigate more. |
|
Yeah this is not going to be fun to fix; I'll get back to you when I have more useful info. For now, leave this PR open. |
|
Did some debugging; upstream goxsys is ignoring a permission error in an unsafe way, which causes it to interpret restricted services as non-services. I'll look into filing a bug upstream. |
|
Filed upstream bug:golang/go#44921 |
hlandau
force-pushed
the
master
branch
2 times, most recently
from
81f5fff
to
cc3fa98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream goxsys deprecated
IsAnInteractiveSession.Refs #17