Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP:Accesible error links #1824

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

StoneBenHMCTS
Copy link
Contributor

Before creating a pull request make sure that:

  • [ x ] commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/EXUI-1571
https://tools.hmcts.net/jira/browse/EXUI-1579

Change description

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ x ] No

RiteshHMCTS and others added 11 commits November 18, 2024 14:51
* Add the fix and tests

* version updated
* checking for the availability of Other type reason

* version updated

* cve

* version updated

* version updated
* Add readCookieService and language information to client context

* Add version

* Add additional language setting on clientcontext

Event guard also sets it

* Make sonar advised change

* Add sonar suggested change

* Update npmpublish.yml

* Add change to make client context always appear with language

* version updated

* release notes updated

* version updated

* version updated

---------

Co-authored-by: Ritesh Dsouza <ritesh.dsouza@HMCTS.net>
* Update event-start.guard.ts

Fix regression issue that overwrites user_task

* Change version

* Update event-start.guard.ts

Add 'en' even if no cookie
Add language to existing client_context object, not just object with user_task

* Add version

* Update event-start.guard.spec.ts

Add helpful test

* update to rel name

---------

Co-authored-by: Josh <josh.glasgow@hmcts.net>
anthonydummer
anthonydummer previously approved these changes Dec 10, 2024
Copy link
Contributor

@connorpgpmcelroy connorpgpmcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olusegz07 olusegz07 force-pushed the branch_frm_d80548e_before_QM branch from 1ba5a5b to b22fa0f Compare December 12, 2024 14:50
@StoneBenHMCTS StoneBenHMCTS changed the base branch from branch_frm_d80548e_before_QM to master January 3, 2025 08:14
@StoneBenHMCTS StoneBenHMCTS dismissed stale reviews from connorpgpmcelroy and anthonydummer January 3, 2025 08:14

The base branch was changed.

Copy link

sonarqubecloud bot commented Jan 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants