Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exui 2609 hearing link case #1830

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Conversation

olusegz07
Copy link
Contributor

Before creating a pull request make sure that:

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:

JIRA link (if applicable)

Change description

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

RiteshHMCTS and others added 15 commits November 18, 2024 14:51
* Add the fix and tests

* version updated
* checking for the availability of Other type reason

* version updated

* cve

* version updated

* version updated
* Add readCookieService and language information to client context

* Add version

* Add additional language setting on clientcontext

Event guard also sets it

* Make sonar advised change

* Add sonar suggested change

* Update npmpublish.yml

* Add change to make client context always appear with language

* version updated

* release notes updated

* version updated

* version updated

---------

Co-authored-by: Ritesh Dsouza <ritesh.dsouza@HMCTS.net>
* Update event-start.guard.ts

Fix regression issue that overwrites user_task

* Change version

* Update event-start.guard.ts

Add 'en' even if no cookie
Add language to existing client_context object, not just object with user_task

* Add version

* Update event-start.guard.spec.ts

Add helpful test

* update to rel name

---------

Co-authored-by: Josh <josh.glasgow@hmcts.net>
* Bug/ex UI 2431 special characters crashing (#1798)

* Character edition before atob change

* Add version

* Remove control characters

* Update case-edit.utils.ts

* Update cases.service.ts

Remove unneccessary log

* Change version for tagging

* Make editions to convert to HTML Entities

* Change version and make slight editions after PR comments

* Change version to tag

* Update cases.service.ts

Remove dead debug code

---------

Co-authored-by: RiteshHMCTS <74713687+RiteshHMCTS@users.noreply.github.com>

* exui-2469-hidden field should be removed from event submission (#1802)

* hidden field should be removed from event submittion

* sonar issue fix

* refactor code

* refactor code

* Refactored to reduce chance of exception bailing out of loop

---------

Co-authored-by: Andy Wilkins <andy.wilkins@hmcts.net>

* exui-2536-issue-with-dynamic-multi-select-list (#1813)

* exui-2536-to update-nested-dynamice-list

* cve

* version updated

* increased scope to the dynamicList and dynamicRadioList

* release notes updated

* notes updated

* moved repeated code to function

* media viewer version update (#1812)

Co-authored-by: RiteshHMCTS <74713687+RiteshHMCTS@users.noreply.github.com>

* release notes updated

* version updated

* revert exui-2469

* updated release notes

* cve

* version updated

* media viewer version updated for release

* release notes updated

---------

Co-authored-by: connorpgpmcelroy <74015088+connorpgpmcelroy@users.noreply.github.com>
Co-authored-by: Andy Wilkins <andy.wilkins@hmcts.net>
Co-authored-by: MunishSharmaHMCTS <112546702+MunishSharmaHMCTS@users.noreply.github.com>
@olusegz07 olusegz07 force-pushed the exui-2609-hearing-link-case branch from c7e132e to 358fc0e Compare December 13, 2024 14:08
Copy link
Contributor

@connorpgpmcelroy connorpgpmcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants