Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update npmpublish.yml #1831

Merged
merged 21 commits into from
Jan 7, 2025
Merged

Update npmpublish.yml #1831

merged 21 commits into from
Jan 7, 2025
+18 −14

Conversation

olusegz07
Copy link
Contributor

Before creating a pull request make sure that:

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/EXUI-2651

Change description

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

@olusegz07 olusegz07 force-pushed the exui-2651-sonar-cloud-analysis-issue branch from b8b336d to f9f79f2 Compare December 16, 2024 14:16
connorpgpmcelroy
connorpgpmcelroy previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@connorpgpmcelroy connorpgpmcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Josh-HMCTS
Josh-HMCTS previously approved these changes Jan 7, 2025
View reviewed changes
StoneBenHMCTS
StoneBenHMCTS previously approved these changes Jan 7, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@olusegz07 olusegz07 merged commit 94b21b2 into master Jan 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StoneBenHMCTS StoneBenHMCTS StoneBenHMCTS approved these changes

@Josh-HMCTS Josh-HMCTS Josh-HMCTS approved these changes

@connorpgpmcelroy connorpgpmcelroy connorpgpmcelroy left review comments

@andywilkinshmcts andywilkinshmcts andywilkinshmcts left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@olusegz07 @andywilkinshmcts @connorpgpmcelroy @Josh-HMCTS @StoneBenHMCTS