Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rules that should be unnecessary #47

Closed
wants to merge 1 commit into from
Closed

Remove rules that should be unnecessary #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions components/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,8 @@ resource "github_organization_ruleset" "default_ruleset" {
required_linear_history = true

pull_request {
dismiss_stale_reviews_on_push = true
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule discourages pushing small changes and fixups as you have to go chasing reviews again

What was the reason this was enabled?

require_code_owner_review = false
required_approving_review_count = 1
require_last_push_approval = true
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule discourages tidy ups for getting a change over the line, say:
Committer A makes change
Committer B tidies up, maybe fixing linting
Now A & B can't approve

This slows things down

Why was this added?

required_review_thread_resolution = true
ConnorOKane-Kainos marked this conversation as resolved.
Show resolved Hide resolved
}
}

Expand Down
Loading