Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSCSSI-421: use triggerV2 #4122

Merged
merged 21 commits into from
Nov 27, 2024
Merged

Conversation

sanjayparekh-hmcts
Copy link
Contributor

Jira link

https://tools.hmcts.net/jira/browse/SSCSSI-421

Change description

Testing done

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@sanjayparekh-hmcts sanjayparekh-hmcts requested a review from a team as a code owner November 8, 2024 11:29
Copy link

github-actions bot commented Nov 8, 2024

CCD diff report

No change

SomeshRA
SomeshRA previously approved these changes Nov 12, 2024
Copy link
Contributor

@SomeshRA SomeshRA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

srochani
srochani previously approved these changes Nov 14, 2024
@sanjayparekh-hmcts sanjayparekh-hmcts dismissed stale reviews from srochani and SomeshRA via 60991be November 15, 2024 16:51
Copy link

github-actions bot commented Nov 18, 2024

Integration Tests results

   82 files  ±0     82 suites  ±0   9m 0s ⏱️ -16s
1 422 tests ±0  1 414 ✅ ±0  8 💤 ±0  0 ❌ ±0 
1 423 runs  ±0  1 415 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit a517b62. ± Comparison against base commit 71e6eeb.

This pull request removes 10 and adds 10 tests. Note that renamed tests count towards both.
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED) [1]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED_WELSH) [0]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_GRANTED) [6]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_REFUSED) [2]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(PROCESS_AUDIO_VIDEO) [5]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(PROCESS_AUDIO_VIDEO_WELSH) [3]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SET_ASIDE_GRANTED) [7]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SET_ASIDE_REFUSED) [9]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SOR_EXTEND_TIME) [8]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SOR_REFUSED) [4]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED) [2]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED_WELSH) [4]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_GRANTED) [0]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_REFUSED) [5]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(PROCESS_AUDIO_VIDEO) [7]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(PROCESS_AUDIO_VIDEO_WELSH) [8]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SET_ASIDE_GRANTED) [3]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SET_ASIDE_REFUSED) [6]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SOR_EXTEND_TIME) [1]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SOR_REFUSED) [9]

♻️ This comment has been updated with latest results.

@srochani srochani merged commit ba861e0 into master Nov 27, 2024
9 checks passed
@srochani srochani deleted the SSCSSI-421-requestTranslationFromWLU branch November 27, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants