Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCaml snippets outdated #345

Open
ComanderP opened this issue Dec 29, 2024 · 1 comment
Open

OCaml snippets outdated #345

ComanderP opened this issue Dec 29, 2024 · 1 comment

Comments

@ComanderP
Copy link

Hello,

First off, I’ve been really enjoying the OCaml version of the book. It’s been a great read so far, and I appreciate the effort that’s gone into adapting the content for different programming languages.

However, while reading, I’ve noticed that some of the OCaml code snippets seem to be outdated for more recent versions of the language (e.g. usage of libraries that are discouraged in modern OCaml, and comments about/definitions of functions that are now in the standard library). There's also some snippets that seem to be misplaced.

I’d be happy to help update the code snippets to match a more recent version of OCaml. If someone could guide me on what I need to touch to change the snippets, I would appreciate it! I assume it's the code inside the chapters in src/content/, but I'd like to be prepared.

Also, again, thanks for creating such an awesome resource.

@drupol
Copy link
Collaborator

drupol commented Dec 29, 2024

Yes that's pretty much it. Modify something then to build a local version of the book, I recommend using Nix, as described in the Readme.

Ping us in case of help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants