Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NickAkhmetov/Visx Conversion #26

Merged
merged 77 commits into from
Oct 23, 2024
Merged

NickAkhmetov/Visx Conversion #26

merged 77 commits into from
Oct 23, 2024

Conversation

NickAkhmetov
Copy link
Collaborator

@NickAkhmetov NickAkhmetov commented Sep 6, 2024 •
edited
Loading

Accomplished items:

Remaining TODOs:

  • Keyboard controls for moving rows/columns
  • Expanding rows to display inline barchart
  • Fix violins?
  • Styling improvements

@NickAkhmetov
start pulling out visualization elements into visx components
1b1ab93
@NickAkhmetov
follow rules of hooks (no returning before all hooks are declared)
358add3
@NickAkhmetov
component stubs, start organizing
ff5629c
@NickAkhmetov
wip
0dde578
@NickAkhmetov
add prettier, start splitting up config contexts
f6eacbd
@NickAkhmetov
improve tsconfig setup, move configs and scales into contexts, lint:fix
be1248a
@NickAkhmetov
wip - organized contexts, added side graphs
1fa321c
@NickAkhmetov
unify bars
322a8e4
@NickAkhmetov
wip violins, added react lint rules
9a7374c
@NickAkhmetov
considering violins "good enough" for now - still need to make sure t…
961af24 
…hey actually look right...
@NickAkhmetov
use fractions - still doesn't really change anything...
53d61cb
@NickAkhmetov
add tooltip
d25baa9
@NickAkhmetov
use correct upper bound
ac64d65
@NickAkhmetov
begin setting up drag and drop/reordering
4344f08
@NickAkhmetov
wip, x/y overlays for dragging, figuring out dnd-kit
1aa349b
@NickAkhmetov
improve row/column dragging
592ce1e
@NickAkhmetov
add axes to bar charts, clean up
d1ae74c
@NickAkhmetov
use more readable numeric tick format
446e483
@NickAkhmetov
add legend to corner
0b56334
@NickAkhmetov
Resizing!
e9af4b7
@NickAkhmetov
use pointer-within collision strategy
080a15f
@NickAkhmetov
improve drag overlay consistency
95c248e
@NickAkhmetov
Fix tooltips
036c669
@NickAkhmetov
try moving dragging to svg to make it more accurate - worked for a bi…
d23b7db 
…t, then sudden performance crash
@NickAkhmetov
add basic axis sorting
a59a415
@NickAkhmetov NickAkhmetov marked this pull request as ready for review September 17, 2024 14:13
NickAkhmetov
NickAkhmetov commented Sep 17, 2024
View reviewed changes
.vscode/settings.json
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set up the ESLint config for v9 and added appropriate linting rules. I can also add a workspace recommendation to install the appropriate VS Code extensions to support this (i.e. dbaeumer.vscode-eslint and cSpell

NickAkhmetov
NickAkhmetov commented Sep 17, 2024
View reviewed changes
src/visualization/animation.ts
Copy link
Collaborator Author

@NickAkhmetov NickAkhmetov Sep 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I avoided editing the visualization directory besides letting ESLint do its thing with spacing etc.

NickAkhmetov and others added 28 commits September 27, 2024 15:51
@NickAkhmetov
fix incorrect counts being used
456f3fc
@NickAkhmetov
pin vitessce to 3.4.9
0f19806
@NickAkhmetov
improve dragging performance via div overlay
f09be48
@NickAkhmetov
get bars to rescale properly on restore
60be723
@NickAkhmetov
fix obs sets loading/unpin vitessce
eaddd19
@NickAkhmetov
fix issues reordering previously-removed rows, improve tooltip position
e26c826
@NickAkhmetov
WIP expanding rows, improvements to context menu state
50dc204
@NickAkhmetov
tooltips for expanded view
4bed6ef
@NickAkhmetov
basic expandable rows implementation
e906164
@NickAkhmetov
fix react hook crash on removal of sample after expansion of differen…
9d2ad68 
…t sample
@NickAkhmetov
avoid duplicate recalculation of row maxes
2644f86
@NickAkhmetov
simplify sortOrder logic by taking out effect and handling sorting in…
d94dc99 
… event handler
@NickAkhmetov
improve appearance of expanded heatmap row by adding a bit of padding
341dbe7
@NickAkhmetov
add other color schemes for heatmap
9d3dae4
@NickAkhmetov
clean up
d1241d2
@NickAkhmetov
remove snap modifier from drag overlay
ba758a9
@NickAkhmetov
reenable dragging with expanded value
4127dfd
@NickAkhmetov
more cleanup
661e1cc
@NickAkhmetov
improve ticks for top/side bar axes, decrease incidence of random bar…
2a8973c 
…s in heatmap, revise heatmap to always use rows to render
@NickAkhmetov
fix tooltips with expanded row
d852ac8
@NickAkhmetov
console log cleanup...
6f136c0
@NickAkhmetov
tooltip fix
a558ee4
@NickAkhmetov
metadata value bars, sort by metadata
275eacc
@NickAkhmetov
Add buttons for all the metadata sort options
05ca055
@NickAkhmetov
remove useless "custom" button
4547b94
@NickAkhmetov
improve metadata bar display
7d4d666
@NickAkhmetov
use sans serif font
ca2d316
@thomcsmits
Merge branch 'main' into nickakhmetov/visx
544e6e5
thomcsmits
thomcsmits approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@thomcsmits thomcsmits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NickAkhmetov NickAkhmetov merged commit 2734da4 into hms-dbmi:main Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcsmits thomcsmits thomcsmits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickAkhmetov @thomcsmits