Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make CNV file optional #132

Merged
merged 1 commit into from
Mar 5, 2024
Merged

feat: make CNV file optional #132

merged 1 commit into from
Mar 5, 2024

Conversation

crfmc
Copy link
Collaborator

@crfmc crfmc commented Feb 20, 2024

Make the CNV file optional and reflect this in the UI:

  • Exclude GAIN and LOH tracks if cnv field is undefined
  • Update cnv item in docs
  • Update cnv input in the UI (remove red border and update input validation)

-feat: exclude GAIN and LOH tracks if cnv field is undefined
-chore: update cnv item in docs
-feat: update cnv input
@crfmc crfmc linked an issue Feb 20, 2024 that may be closed by this pull request
@crfmc crfmc changed the title Make CNV File Optional feat: make CNV file optional Feb 20, 2024
@@ -23,7 +23,7 @@ For each sample, you need to prepare the following information in a JSON object.
| `cancer` | `string` | Required. Type of a cancer. |
| `assembly` | `'hg38'` or `'hg19'` | Required. Assembly. |
| `sv` | `string` | Required. An URL of the SV bedpe file (`.bedpe`). |
| `cnv` | `string` | Required. An URL of the CNV text file (`.tsv`). |
| `cnv` | `string` | Optional. An URL of the CNV text file (`.tsv`). |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the documentation as well!

Copy link
Member

@sehilyi sehilyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this change!! Also congrats on your first contribution! 🥳

@sehilyi sehilyi merged commit 86a6e51 into master Mar 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the CNV file optional
2 participants