Skip to content

Commit

Permalink
Fix minor but and update changelog.
Browse files Browse the repository at this point in the history
  • Loading branch information
srpiatt committed Nov 15, 2023
1 parent 237c435 commit 5020043
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 2 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,15 @@

All notable changes to this project will be documented in this file. As our fork has diverged from AWS SWB mainline branch, we are noting the SWB version and the lab version together, as <swb version>\_<lab version>, starting from SWB mainline, 5.0.0.

## [5.0.0_1.2.1](https://github.com/hms-dbmi/service-workbench-on-aws/compare/v5.0.0_1.2.0...v5.0.0_1.2.1) (11/15/2023)

- Update windows sync to auto-start on user login.
- Add message for windows users when a study is attached to note that study files will take time to sync on start and before stop.
- Add a modal notice on study permission edit when a user would be impacted by permission change/removal.
- Fix bug where workspace configuration deprecation notice errantly shows on workspace view page on reload.

## [5.0.0_1.2.0](https://github.com/hms-dbmi/service-workbench-on-aws/compare/v5.0.0_1.1.2...v5.0.0_1.2.0) (09/28/2023)

- Allow more than 100 RStudio instances to be launched in one host account, by dynamically creating load balancers-
bypassing AWS 100 target group limit.
- Added support for multiple ALBs. New ALB will be created when the limit for existing ALB exceeds
Expand All @@ -19,6 +26,7 @@ All notable changes to this project will be documented in this file. As our fork
- Update to build proxy lambda layer and with requirements.

## [5.0.0_1.1.1](https://github.com/hms-dbmi/service-workbench-on-aws/compare/v5.0.0_1.1.0...v5.0.0_1.1.1) (08/10/2023)

- Update serverless templates to use an empty string for aws profile.
- Update nodejs and aws-sdk versions.
- Cherry pick [a0c7eeed34eea02ec56f49411cf499d1c59f0d3a](https://github.com/awslabs/service-workbench-on-aws/commit/a0c7eeed34eea02ec56f49411cf499d1c59f0d3a) to upgrade nodejs version and dependencies for lambda runtimes.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ class ScEnvironmentDetailPage extends React.Component {
swallowError(store.load());
store.startHeartbeat();
}

if (!isStoreReady(this.envTypesStore)) {
swallowError(this.envTypesStore.load());
}
}

componentWillUnmount() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,5 @@ export default inject(
'projectsStore',
'envTypesStore',
'userDisplayName',
'envTypesStore',
'userStore',
)(withRouter(observer(ScEnvironmentsList)));
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export default function FilterBox({ mode = 'or', filters = [], fields, onFilter
}

return (
<Segment color={active && 'blue'}>
<Segment color={active ? 'blue' : undefined}>
<Accordion fluid>
<Accordion.Title index={0} active={active} onClick={toggleActive()}>
<Icon name="filter" />
Expand Down

0 comments on commit 5020043

Please sign in to comment.