Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALS-5505] Update to add 'and' to scanner filter when more than one filter condition exists #155

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

srpiatt
Copy link
Collaborator

@srpiatt srpiatt commented Dec 13, 2023

When a user logs into SWB as a researcher the API returns a validation error.

In my local, this returns an error message (although id doesn't seem to display a message in prod). Regardless, because of this the env data does not successfully refresh without a manual page reload.

The cause of the validation error is the applied since and createdBy filters. When multiple filters were applied, it was sending the filter expression as #c = :c #u = :u instead of #c = :c and #u = :u, which is required for scanner operations.

Checklist:

  • Have you successfully tested with your changes locally?
  • Have you successfully deployed to an AWS account with your changes?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@srpiatt srpiatt added the bug Something isn't working label Dec 13, 2023
@srpiatt srpiatt self-assigned this Dec 13, 2023
@srpiatt srpiatt merged commit 6ab01b8 into byon-main Dec 14, 2023
6 checks passed
@srpiatt srpiatt deleted the bugfix/workspaces-filter-conflict branch December 20, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants