Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slashes to regex string so emails can pass validation on register page #157

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

srpiatt
Copy link
Collaborator

@srpiatt srpiatt commented Dec 20, 2023

validatorjs schema regex fields need slashes before and after the regex, or else it returns a validation error. This blocks users from registering.

Checklist:

  • Have you successfully tested with your changes locally?
  • Have you successfully deployed to an AWS account with your changes?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@srpiatt srpiatt added the bug Something isn't working label Dec 20, 2023
@srpiatt srpiatt self-assigned this Dec 20, 2023
@srpiatt srpiatt force-pushed the bugfix/register-email-regex-validation branch from 3697761 to abb0bd5 Compare December 21, 2023 18:04
@srpiatt srpiatt marked this pull request as ready for review December 21, 2023 18:11
@srpiatt
Copy link
Collaborator Author

srpiatt commented Dec 21, 2023

Reviewed in office hours, December 21, 2023.

@srpiatt srpiatt merged commit 1b5c2fa into byon-main Dec 21, 2023
4 checks passed
@srpiatt srpiatt deleted the bugfix/register-email-regex-validation branch December 21, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants