Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ALS-5982] Move conda env config to install_kernel script #170

Merged
merged 1 commit into from
Mar 1, 2024
Merged

[ALS-5982] Move conda env config to install_kernel script #170

merged 1 commit into from
Mar 1, 2024

Conversation

srpiatt
Copy link
Collaborator

@srpiatt srpiatt commented Mar 1, 2024

  • Move conda env config to install kernel script, as FISMA does not use the new environment split bootstrap but the old, deprecated one that was not getting this new config step. Probably need to update FISMA to use the new bootstrap scripts for all workspace types.

Checklist:

  • Have you successfully deployed to an AWS account with your changes?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@srpiatt srpiatt added the enhancement New feature or request label Mar 1, 2024
@srpiatt srpiatt self-assigned this Mar 1, 2024
@github-actions github-actions bot added the size/s label Mar 1, 2024
@srpiatt srpiatt requested a review from JamesPeck March 1, 2024 16:01
@srpiatt srpiatt changed the title [ALS-5982] Bugfix/kernels [ALS-5982] Move conda env config to install_kernel script Mar 1, 2024
@srpiatt srpiatt merged commit ff5c722 into byon-main Mar 1, 2024
3 checks passed
@srpiatt srpiatt deleted the bugfix/kernels branch March 1, 2024 19:40
@srpiatt srpiatt restored the bugfix/kernels branch March 1, 2024 19:40
@srpiatt srpiatt deleted the bugfix/kernels branch March 1, 2024 19:40
Luke-Sikina pushed a commit that referenced this pull request Mar 21, 2024
@srpiatt @Luke-Sikina
[ALS-5982] Move conda env config to install_kernel script (#170)
20e832d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesPeck JamesPeck Awaiting requested review from JamesPeck

Assignees

@srpiatt srpiatt

Labels
enhancement New feature or request size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@srpiatt