Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use last fileGrp as default #60

Closed
bertsky opened this issue Mar 1, 2023 · 3 comments
Closed

use last fileGrp as default #60

bertsky opened this issue Mar 1, 2023 · 3 comments

Comments

@bertsky
Copy link
Contributor

bertsky commented Mar 1, 2023

def use_file_group(self) -> str:
return 'OCR-D-IMG'

This often does not exist in real life (DFG profile has DEFAULT or MAX or ORIGINAL), and has empty PAGE XML anyway. So IMO it would make more sense to pick the last fileGrp with PAGE-XML mimetype by default.

(Or even better, make this configurable as well, like the default image fileGrp.)

@hnesk
Copy link
Owner

hnesk commented Mar 3, 2023

The method use_file_goup() is just the fallback, if not overridden in subclasses. For nearly all subclasses there is a property file_group that will be used instead. I changed the configurator to always select the last entry now.
Keeping the ticket open for making file_group selection also configurable.

@bertsky
Copy link
Contributor Author

bertsky commented Mar 3, 2023

For nearly all subclasses there is a property file_group that will be used instead.

Oh right! Sry, forgot all about that.

I changed the configurator to always select the last entry now.

Thank you!

@bertsky
Copy link
Contributor Author

bertsky commented Jun 28, 2023

I changed the configurator to always select the last entry now.

Thank you!

Which did of course solve the issue.

@bertsky bertsky closed this as completed Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants