Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated nyc_taxi #151

Merged
merged 20 commits into from
Oct 20, 2023
Merged

Updated nyc_taxi #151

merged 20 commits into from
Oct 20, 2023

Conversation

jbednar
Copy link
Contributor

@jbednar jbednar commented May 26, 2021

Updated the nyc_taxi example:

  • Updated to current versions of HoloViz tools
  • Fixed AttributeError: 'Dataset' object has no attribute 'Count' #144 ; needed updating to match changes in HoloViews datashader support
  • Switched away from broken tile sources (worked fine locally, but not on examples.pyviz.org or other deployments)
  • Removed distracting ds.count('passenger_count') - confusingly seems to count the total passengers, but really only counts the number of records where that field is not missing
  • Replaced ancient Hot colormap with colorcet.fire; Hot was better than other hot versions, but still not properly uniform
  • Updated notebook and dashboard to use rasterize now that they are well supported in Bokeh

To do:

  • Should update to Datashader 0.13 when released to get the dynspread fixes.
  • Update last cell of nyc_taxi-nongeo.ipynb; currently breaks with error "No plotting class for Dataset found".
  • Fix anaconda-project.yml to avoid dependencies/packages issue
  • When above are done, run anaconda-project lock and update the nyc_taxi/anaconda-project-lock.yml file

@github-actions
Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@github-actions
Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@maximlt maximlt merged commit c9c25df into main Oct 20, 2023
9 checks passed
@maximlt maximlt deleted the taxi21 branch October 20, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'Dataset' object has no attribute 'Count'
3 participants